Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version parameter to websocket routes #1760

Merged
merged 5 commits into from
Jun 28, 2020
Merged

Add version parameter to websocket routes #1760

merged 5 commits into from
Jun 28, 2020

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Jan 9, 2020

Resolves #1757

@ahopkins ahopkins changed the title Issue1757 Add version parameter to websocket routes Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020 •
edited
Loading

Codecov Report

Merging #1760 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1760      +/-   ##
==========================================
+ Coverage   91.53%   91.63%   +0.09%     
==========================================
  Files          27       27              
  Lines        3000     3000              
  Branches      545      545              
==========================================
+ Hits         2746     2749       +3     
+ Misses        174      172       -2     
+ Partials       80       79       -1
Impacted Files Coverage Δ
sanic/app.py 93.02% <ø> (ø)
sanic/server.py 74.33% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6239fa4...b3b00b4. Read the comment docs.

seemethere
seemethere previously requested changes Jan 9, 2020
View reviewed changes
sanic/app.py Show resolved Hide resolved
sanic/app.py Outdated Show resolved Hide resolved
sanic/app.py Show resolved Hide resolved
sanic/app.py Show resolved Hide resolved
@sjsadowski
Copy link
Contributor

@seemethere any further commentary after @ahopkins response

@sjsadowski
Copy link
Contributor

@ahopkins providing there's no further commentary, if you'll resolve the conflicts I'll get this merged.

@Tronic Tronic mentioned this pull request Mar 30, 2020
Closed
@Tronic
Copy link
Member

Tronic commented Apr 9, 2020

@ahopkins The conflict still needs resolving.

@ahopkins ahopkins dismissed seemethere’s stale review April 19, 2020 20:48

Order consistency per note.

@ahopkins
Copy link
Member Author

@sjsadowski

@ahopkins
Copy link
Member Author

ahopkins commented Jun 3, 2020

@huge-success/sanic-core-devs Can someone review and approve so we can merge?

@ahopkins ahopkins merged commit 6c8e20a into master Jun 28, 2020
@ahopkins ahopkins deleted the issue1757 branch June 28, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldaeschle danieldaeschle danieldaeschle left review comments

@Tronic Tronic Tronic approved these changes

@seemethere seemethere seemethere left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Websocket doesn't work when using version parameter
5 participants
@ahopkins @sjsadowski @Tronic @seemethere @danieldaeschle